CLOUDP-260438: Fix redacted integration comparisons #1684
Conversation
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
josvazg
requested review from
filipcirtog,
helderjs,
igor-karpukhin,
roothorp,
s-urbaniak and
slaskawi
| } | ||
|
|
||
| *strPtr = str[len(str)-charCount:] | ||
| func areIntegrationsEqual(_, _ *aliasThirdPartyIntegration) bool { |
There was a problem hiding this comment.
It's probably a matter of taste but I would extract this into an interface and provide an "AlwaysApplyComparer" or something along these lines. Just to get this stop-the-bleeding patch code out of the sight.
Feel free to ignore this suggestion if you think otherwise.
There was a problem hiding this comment.
Not sure is worth it. We are going to actually write quite some new code once we need to actually compare. We just do not know what that code is now, so having interfaces seems premature. For instance, if we go for implicit evaluation these interfaces break, because we need input from 3 sources, Atlas, Spec and annotations.
s-urbaniak
left a comment
s-urbaniak
left a comment
There was a problem hiding this comment.
lgtm but I'd like to leave a final review to @helderjs and/or @igor-karpukhin as well.
All Submissions: