CLOUDP-289150: Fix private endpoint conflict between sub-resource and new CRD #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
josvazg
reviewed
Dec 18, 2024
| } | ||
| } | ||
|
|
||
| return len(set.DeprecatedDifference(specPEs, atlasPEs)) == 0 |
Collaborator
There was a problem hiding this comment.
why are we using a deprecated diff on new code?
Collaborator
Author
There was a problem hiding this comment.
As mentioned in previous comments, while there's new addition to this part of the code, it still depends on deprecated types/interfaces unless fully refactor to use translation layer, which is not a goal.
josvazg
approved these changes
Dec 18, 2024
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM, but would prefer not to keep on using deprecated calls on new changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).