Skip to content

CLOUDP-140883: Check unset conditions #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2022
Merged

CLOUDP-140883: Check unset conditions #728

merged 4 commits into from
Oct 25, 2022

Conversation

@fabritsius
Copy link
Contributor

@fabritsius fabritsius commented Oct 24, 2022

No description provided.

@fabritsius fabritsius marked this pull request as ready for review October 25, 2022 12:45
igor-karpukhin
igor-karpukhin approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

helderjs
helderjs approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabritsius fabritsius merged commit 26e3401 into main Oct 25, 2022
@fabritsius fabritsius deleted the check-unset-conditions branch October 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helderjs helderjs helderjs approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@Sugar-pack Sugar-pack Awaiting requested review from Sugar-pack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabritsius @helderjs @igor-karpukhin