CLOUDP-78181: project ip access list (part 1) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 25, 2021 17:33
…to main � Conflicts: � README.md
added 2 commits
February 5, 2021 20:47
vasilevp
suggested changes
Feb 8, 2021
| return err | ||
| } | ||
| } | ||
| // Go doesn't support XOR, but uses '!=' instead: https://stackoverflow.com/a/23025720/614239 |
Contributor
There was a problem hiding this comment.
[nit] but != literally is XOR for booleans 🙂
vasilevp
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for project IP access list. Anything in Atlas that doesn't match the spec is removed from Atlas, the rest is added. This ensures that if any ip access list entry is removed from the spec - it will be removed in Atlas as well.
The basic int test is added.
More unit and int tests will be added in the next PR