Cloudp 83092 upload dockerfiles to s3 #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:mongodb/mongodb-kubernetes-operator into CLOUDP-83092_add_release_task_for_init_containers
chatton
changed the base branch from
master
to
CLOUDP-83092_add_context_image_for_agents
chatton
commented
Apr 21, 2021
inventory.yaml
Outdated
|
|
||
| labels: | ||
| quay.expires-after: 48h | ||
| quay.expires-after: $(inputs.params.expire_after) |
Contributor
Author
There was a problem hiding this comment.
when releasing, we want to specify "Never", not "48h"
…83092_upload_dockerfiles_to_s3
…83092_upload_dockerfiles_to_s3
Base automatically changed from
CLOUDP-83092_add_context_image_for_agents
to
master
April 23, 2021 16:39
chatton
commented
Apr 26, 2021
|
|
||
| args = { | ||
|
|
||
| def _build_agent_args(config: DevConfig) -> Dict[str, str]: |
Contributor
Author
There was a problem hiding this comment.
these values are shared in both agent images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stages to inventory.yaml which will upload the generated Dockerfiles to the dockerfile s3 bucket.