Skip to content

Conversation

@chatton
Copy link
Contributor

@chatton chatton commented Apr 23, 2021

All Submissions:

The release flag was being triggered with every task. A value of true was returned if the field was specified at all, it does not account for the value of the bool.

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@chatton chatton requested a review from bznein April 23, 2021 15:32
Copy link
Contributor

@bznein bznein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really ugly but I can't really think of a nicer way to do it, I tried some combinations and they don't work... LGTM!

Copy link
Contributor

@rodrigovalin rodrigovalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the job!

@chatton chatton merged commit 2b50bc9 into master Apr 23, 2021
@chatton chatton deleted the fix_incorrect_arg_parse_field branch April 23, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants