Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go linting pre commit hook #88

Merged
merged 21 commits into from Jul 8, 2020
Merged

Go linting pre commit hook #88

merged 21 commits into from Jul 8, 2020

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Jul 3, 2020

This PR

WIP PR for adding a pre-commit hook linting step for our Go files.

Together with some fixes to resolve some linting errors.

Notes:

  • Before proceeding to the next step we need to decide which of the errors that the linters we actually want to fix and which are ok to be ignored; I'll prepare a list soon
  • golancli-lint supports a number of different linters, only some of which are enabled by default. We should check which ones we want and which not. Again I'll come up with a list soon.

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@bznein bznein added the wip label Jul 3, 2020
@bznein bznein marked this pull request as ready for review July 7, 2020 16:53
@bznein bznein removed the wip label Jul 8, 2020
Copy link
Contributor

@LouisPlisso LouisPlisso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bznein bznein merged commit 1603c75 into master Jul 8, 2020
@bznein bznein deleted the Go-Linting-PreCommit-Hook branch July 8, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants