Add diagnostic tool selection with optional DTOOL/DTOOLARGS flags in … #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diagnostic script
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| title: Add diagnostic tool selection with DTOOL and DTOOLARGS support | |||
Contributor
There was a problem hiding this comment.
Suggested change
| title: Add diagnostic tool selection with DTOOL and DTOOLARGS support | |
| title: Add support to select diagnostic tool with DTOOL and DTOOLARGS |
| ocExists=$? | ||
|
|
||
| command -v kubectl >/dev/null 2>&1 | ||
| kcExists=$? |
Contributor
There was a problem hiding this comment.
Suggested change
| kcExists=$? | |
| kubectlExists=$? |
Contributor
There was a problem hiding this comment.
nit: I think it's better to be explicit about what exactly we are talking about. wdyt?
| kcExists=$? | ||
|
|
||
| # Let the user override via environment variable | ||
| dToolUser=${DTOOL:-""} |
Contributor
There was a problem hiding this comment.
kubectl and oc are not really the diagnostic tools right? they are just tools to interact with the api server. So I would recommend naming this to something else. Maybe clientTool, kubeClientTool or something like that.
| local e match=$1 | ||
| shift | ||
| for e; do [[ "${e}" == "${match}" ]] && return 0; done | ||
| for e; do [[ "$e" == "$match" ]] && return 0; done |
Contributor
There was a problem hiding this comment.
is this change necessary? this might upset the shellcheck. or the changed version is better suited for shellcheck? 😆
|
|
||
| # Let the user override via environment variable | ||
| dToolUser=${DTOOL:-""} | ||
| dToolUserArgs=${DTOOLARGS:-""} |
Contributor
There was a problem hiding this comment.
what exactly is the motivation to introduce this? do we want users to be able to configure the kubeconfig?
Contributor
|
It's been some time and we didn't hear anything from the author. I will go ahead and close this PR. |
Julien-Ben
pushed a commit
that referenced
this pull request
Oct 16, 2025
Bumps the pip-deps group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [pymongo](https://github.com/mongodb/mongo-python-driver) | `4.15.2` | `4.15.3` | | [python-ldap](https://github.com/python-ldap/python-ldap) | `3.4.4` | `3.4.5` | | [isort](https://github.com/PyCQA/isort) | `6.1.0` | `7.0.0` | | [botocore](https://github.com/boto/botocore) | `1.40.46` | `1.40.51` | | [boto3](https://github.com/boto/boto3) | `1.40.46` | `1.40.51` | | [types-python-dateutil](https://github.com/typeshed-internal/stub_uploader) | `2.9.0.20250822` | `2.9.0.20251008` | | [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) | `16.0.1` | `16.1` | Updates `pymongo` from 4.15.2 to 4.15.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mongodb/mongo-python-driver/releases">pymongo's releases</a>.</em></p> <blockquote> <h2>PyMongo 4.15.3</h2> <p>Community notes: <a href="https://www.mongodb.com/community/forums/t/pymongo-4-15-3-released/329778">https://www.mongodb.com/community/forums/t/pymongo-4-15-3-released/329778</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mongodb/mongo-python-driver/blob/master/doc/changelog.rst">pymongo's changelog</a>.</em></p> <blockquote> <h2>Changes in Version 4.15.3 (2025/10/07)</h2> <p>Version 4.15.3 is a bug fix release.</p> <ul> <li>Fixed a memory leak when raising :class:<code>bson.errors.InvalidDocument</code> with C extensions.</li> <li>Fixed the return type of the :meth:<code>~pymongo.asynchronous.collection.AsyncCollection.distinct</code>, :meth:<code>~pymongo.synchronous.collection.Collection.distinct</code>, :meth:<code>pymongo.asynchronous.cursor.AsyncCursor.distinct</code>, and :meth:<code>pymongo.asynchronous.cursor.AsyncCursor.distinct</code> methods.</li> </ul> <p>Issues Resolved ...............</p> <p>See the <code>PyMongo 4.15.3 release notes in JIRA</code>_ for the list of resolved issues in this release.</p> <p>.. _PyMongo 4.15.3 release notes in JIRA: <a href="https://jira.mongodb.org/secure/ReleaseNote.jspa?projectId=10004&version=47293">https://jira.mongodb.org/secure/ReleaseNote.jspa?projectId=10004&version=47293</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mongodb/mongo-python-driver/commit/611681140700c774d606d0cc1bce288b2b6683f8"><code>6116811</code></a> PYTHON-5609 Prepare for 4.15.3 Release (<a href="https://redirect.github.com/mongodb/mongo-python-driver/issues/2584">#2584</a>)</li> <li><a href="https://github.com/mongodb/mongo-python-driver/commit/fef10d26aa52d2ccab82c8b74e730b3ef3187692"><code>fef10d2</code></a> PYTHON-5596 Fix return type for distinct methods (<a href="https://redirect.github.com/mongodb/mongo-python-driver/issues/2576">#2576</a>) [v4.15] (<a href="https://redirect.github.com/mongodb/mongo-python-driver/issues/2583">#2583</a>)</li> <li><a href="https://github.com/mongodb/mongo-python-driver/commit/039c35ba63a2479536975c42bd9eed5d9308c4ca"><code>039c35b</code></a> [v4.15] PYTHON-5571 - Fix memory leak when raising InvalidDocument with C ext...</li> <li><a href="https://github.com/mongodb/mongo-python-driver/commit/a71c96d2ed1a0bfe03d96abed0b2f93dc985febf"><code>a71c96d</code></a> BUMP 4.15.3.dev0</li> <li>See full diff in <a href="https://github.com/mongodb/mongo-python-driver/compare/4.15.2...4.15.3">compare view</a></li> </ul> </details> <br /> Updates `python-ldap` from 3.4.4 to 3.4.5 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/python-ldap/python-ldap/releases">python-ldap's releases</a>.</em></p> <blockquote> <h2>3.4.5</h2> <p>Released 3.4.5 2025-10-10</p> <p>Security fixes:</p> <ul> <li>CVE-2025-61911 (GHSA-r7r6-cc7p-4v5m): Enforce <code>str</code> input in <code>ldap.filter.escape_filter_chars</code> with <code>escape_mode=1</code>; ensure proper escaping. (thanks to lukas-eu)</li> <li>CVE-2025-61912 (GHSA-p34h-wq7j-h5v6): Correct NUL escaping in <code>ldap.dn.escape_dn_chars</code> to <code>\00</code> per RFC 4514. (thanks to aradona91)</li> </ul> <p>Fixes:</p> <ul> <li>ReconnectLDAPObject now properly reconnects on UNAVAILABLE, CONNECT_ERROR and TIMEOUT exceptions (previously only SERVER_DOWN), fixing reconnection issues especially during server restarts</li> <li>Fixed syncrepl.py to use named constants instead of raw decimal values for result types</li> <li>Fixed error handling in SearchNoOpMixIn to prevent a undefined variable error</li> </ul> <p>Tests:</p> <ul> <li>Added comprehensive reconnection test cases including concurrent operation handling and server restart scenarios</li> </ul> <p>Doc/</p> <ul> <li>Updated installation docs and fixed various documentation typos</li> <li>Added ReadTheDocs configuration file</li> </ul> <p>Infrastructure:</p> <ul> <li>Add testing and document support for Python 3.13</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/python-ldap/python-ldap/blob/python-ldap-3.4.5/CHANGES">python-ldap's changelog</a>.</em></p> <blockquote> <p>Released 3.4.5 2025-10-10</p> <p>Security fixes:</p> <ul> <li>CVE-2025-61911 (GHSA-r7r6-cc7p-4v5m): Enforce <code>str</code> input in <code>ldap.filter.escape_filter_chars</code> with <code>escape_mode=1</code>; ensure proper escaping. (thanks to lukas-eu)</li> <li>CVE-2025-61912 (GHSA-p34h-wq7j-h5v6): Correct NUL escaping in <code>ldap.dn.escape_dn_chars</code> to <code>\00</code> per RFC 4514. (thanks to aradona91)</li> </ul> <p>Fixes:</p> <ul> <li>ReconnectLDAPObject now properly reconnects on UNAVAILABLE, CONNECT_ERROR and TIMEOUT exceptions (previously only SERVER_DOWN), fixing reconnection issues especially during server restarts</li> <li>Fixed syncrepl.py to use named constants instead of raw decimal values for result types</li> <li>Fixed error handling in SearchNoOpMixIn to prevent a undefined variable error</li> </ul> <p>Tests:</p> <ul> <li>Added comprehensive reconnection test cases including concurrent operation handling and server restart scenarios</li> </ul> <p>Doc/</p> <ul> <li>Updated installation docs and fixed various documentation typos</li> <li>Added ReadTheDocs configuration file</li> </ul> <p>Infrastructure:</p> <ul> <li>Add testing and document support for Python 3.13</li> </ul> <hr /> <p>Released 3.4.4 2022-11-17</p> <p>Fixes:</p> <ul> <li>Reconnect race condition in ReconnectLDAPObject is now fixed</li> <li>Socket ownership is now claimed once we've passed it to libldap</li> <li>LDAP_set_option string formats are now compatible with Python 3.12</li> </ul> <p>Doc/</p> <ul> <li>Security Policy was created</li> <li>Broken article links are fixed now</li> <li>Bring Conscious Language improvements</li> </ul> <p>Infrastructure:</p> <ul> <li>Add testing and document support for Python 3.10, 3.11, and 3.12</li> </ul> <hr /> <p>Released 3.4.3 2022-09-15</p> <p>This is a minor release to bring back the removed OPT_X_TLS option. Please note, it's still a deprecated option and it will be removed in 3.5.0.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-ldap/python-ldap/commit/bf666e918615b00dbcd1bbe71542522eedfdffc1"><code>bf666e9</code></a> Prepare a new release</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/464fddacd63092d6e01c62a38316a713c30ca98a"><code>464fdda</code></a> Merge commit from fork</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/9f5b2effbafdf7af0e7064a7aa42d2739d373bd7"><code>9f5b2ef</code></a> Merge commit from fork</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/f49bb2dd2234f25404ad1679786de007444ce219"><code>f49bb2d</code></a> Package python-ldap with pyproject.toml (<a href="https://redirect.github.com/python-ldap/python-ldap/issues/589">#589</a>)</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/6ee881c1d32d9589d68539021091fac19fa5a9e6"><code>6ee881c</code></a> Add support for Python 3.13 (<a href="https://redirect.github.com/python-ldap/python-ldap/issues/576">#576</a>)</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/74c6eeb52ed68f24a8a66937252ef213dd1ce85a"><code>74c6eeb</code></a> docs(ldapobject): fix typo in docstring</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/8a6586241e59b8154d3867dd8d0e7f96e42daa31"><code>8a65862</code></a> fix(controls): make sure msg_id is not undefined in error case</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/73b3ec338f81711ef04563f5d0a63b52615ae313"><code>73b3ec3</code></a> fix(ReconnectLDAPObject): Also reconnect on UNAVILABLE, CONNECT_ERROR and TIM...</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/94c6ab2d7f70bb88101428857b22fccb4d434ffd"><code>94c6ab2</code></a> test: Implement test cases for reconnection handling</li> <li><a href="https://github.com/python-ldap/python-ldap/commit/cc987235309b3ec6ab0829b95ab3bd6ee1c40b2f"><code>cc98723</code></a> Add readthedocs configuration file</li> <li>Additional commits viewable in <a href="https://github.com/python-ldap/python-ldap/compare/python-ldap-3.4.4...python-ldap-3.4.5">compare view</a></li> </ul> </details> <br /> Updates `isort` from 6.1.0 to 7.0.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PyCQA/isort/releases">isort's releases</a>.</em></p> <blockquote> <h2>7.0.0</h2> <h2>Changes</h2> <h2>:boom: Breaking Changes</h2> <ul> <li>Drop support for Python 3.9 (<a href="https://redirect.github.com/PyCQA/isort/issues/2430">#2430</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> </ul> <h2>:rocket: Features</h2> <ul> <li>Show absolute paths in skipped file messages (<a href="https://redirect.github.com/PyCQA/isort/issues/2416">#2416</a>) <a href="https://github.com/pranlawate"><code>@pranlawate</code></a></li> </ul> <h2>:beetle: Fixes</h2> <ul> <li>Some fixes for Python 3.14 (<a href="https://redirect.github.com/PyCQA/isort/issues/2433">#2433</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> <li>Test on <code>3.14</code> and fix any bugs (<a href="https://redirect.github.com/PyCQA/isort/issues/2425">#2425</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> <li>Update CHANGELOG.md + Fix Formatting and Grammar (<a href="https://redirect.github.com/PyCQA/isort/issues/2419">#2419</a>) <a href="https://github.com/lukbrew25"><code>@lukbrew25</code></a></li> <li>Fix output of hanging indent for long lines with noqa (<a href="https://redirect.github.com/PyCQA/isort/issues/2407">#2407</a>) <a href="https://github.com/matan1008"><code>@matan1008</code></a></li> </ul> <h2>:construction_worker: Continuous Integration</h2> <ul> <li>Format with <code>ruff</code> instead of <code>black</code> (<a href="https://redirect.github.com/PyCQA/isort/issues/2432">#2432</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> <li>Target 3.10 for <code>ruff</code> (<a href="https://redirect.github.com/PyCQA/isort/issues/2431">#2431</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> <li>Update development dependencies to latest version (<a href="https://redirect.github.com/PyCQA/isort/issues/2426">#2426</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> <li>docs: update pre-commit examples to version 6.1.0 (<a href="https://redirect.github.com/PyCQA/isort/issues/2413">#2413</a>) <a href="https://github.com/pranlawate"><code>@pranlawate</code></a></li> <li>Small cleanup for developer environment (<a href="https://redirect.github.com/PyCQA/isort/issues/2418">#2418</a>) <a href="https://github.com/DanielNoord"><code>@DanielNoord</code></a></li> </ul> <h2>:package: Dependencies</h2> <ul> <li>Bump actions/setup-python from 5 to 6 in the github-actions group (<a href="https://redirect.github.com/PyCQA/isort/issues/2411">#2411</a>) @<a href="https://github.com/apps/dependabot">dependabot[bot]</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PyCQA/isort/blob/main/CHANGELOG.md">isort's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>NOTE: isort follows the <a href="https://semver.org/">semver</a> versioning standard. Find out more about isort's release policy <a href="https://pycqa.github.io/isort/docs/major_releases/release_policy">here</a>.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PyCQA/isort/commit/0a09c783808cfe77bb3269250f663ff733d23302"><code>0a09c78</code></a> Merge pull request <a href="https://redirect.github.com/PyCQA/isort/issues/2433">#2433</a> from DanielNoord/python-314</li> <li><a href="https://github.com/PyCQA/isort/commit/0fee794a05b5d0c471ac80bc8943f9843ca29644"><code>0fee794</code></a> Add 3.14 to <code>stdlibds</code></li> <li><a href="https://github.com/PyCQA/isort/commit/332a1ad0b68bf3a3acac055b0ec3666408b3b425"><code>332a1ad</code></a> Bump <code>zstandard</code> for 3.14 compat</li> <li><a href="https://github.com/PyCQA/isort/commit/f756e5653afcf6d79ec4d0240b1868cbebd8fafd"><code>f756e56</code></a> Merge pull request <a href="https://redirect.github.com/PyCQA/isort/issues/2432">#2432</a> from DanielNoord/ruff-it-up</li> <li><a href="https://github.com/PyCQA/isort/commit/52f5134889d345ff35afdcb86501c8221b804c70"><code>52f5134</code></a> Format with <code>ruff</code> instead of <code>black</code></li> <li><a href="https://github.com/PyCQA/isort/commit/012aa69fcadb3c89ff92a3d96aa449be7ae6746f"><code>012aa69</code></a> Merge pull request <a href="https://redirect.github.com/PyCQA/isort/issues/2431">#2431</a> from DanielNoord/ruff-it-up</li> <li><a href="https://github.com/PyCQA/isort/commit/89773dbb371192541092657972a74e9ce0bbbc74"><code>89773db</code></a> Target 3.10 with <code>ruff</code></li> <li><a href="https://github.com/PyCQA/isort/commit/933e382f98a0c77b4c6e33c4e3ef12bd57192884"><code>933e382</code></a> Merge pull request <a href="https://redirect.github.com/PyCQA/isort/issues/2430">#2430</a> from DanielNoord/drop-39</li> <li><a href="https://github.com/PyCQA/isort/commit/8b6e00cbe643a216da57fed4baa282d0a4a1b829"><code>8b6e00c</code></a> Remove support for Python 3.9</li> <li><a href="https://github.com/PyCQA/isort/commit/b5f9f296ad873734e8caa3a731f27360648d9b37"><code>b5f9f29</code></a> Bump profile plugin to 3.10+ and re-lock</li> <li>Additional commits viewable in <a href="https://github.com/PyCQA/isort/compare/6.1.0...7.0.0">compare view</a></li> </ul> </details> <br /> Updates `botocore` from 1.40.46 to 1.40.51 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/boto/botocore/commit/d275003f1618e864ac5b45db5670f4f5c3560953"><code>d275003</code></a> Merge branch 'release-1.40.51'</li> <li><a href="https://github.com/boto/botocore/commit/60c4c5b52657f6b527669b933aace4e4c423f280"><code>60c4c5b</code></a> Bumping version to 1.40.51</li> <li><a href="https://github.com/boto/botocore/commit/e55cf7c0ec65aa0eefb247395755e3bd4e3dbaa0"><code>e55cf7c</code></a> Update to latest models</li> <li><a href="https://github.com/boto/botocore/commit/36e45455015f47b18823faab7f19638e85237a35"><code>36e4545</code></a> Merge pull request <a href="https://redirect.github.com/boto/botocore/issues/3576">#3576</a> from boto/dependabot/github_actions/github/codeql-ac...</li> <li><a href="https://github.com/boto/botocore/commit/3dd950f6c25136c249d1b8c2122b896b033ecb35"><code>3dd950f</code></a> Bump github/codeql-action from 3.30.1 to 4.30.8</li> <li><a href="https://github.com/boto/botocore/commit/8d33050a8d49901b780602488aca77a392e32dc6"><code>8d33050</code></a> remove License Classifier Deprecation and use up to date license setup (<a href="https://redirect.github.com/boto/botocore/issues/3575">#3575</a>)</li> <li><a href="https://github.com/boto/botocore/commit/c2ea08e8e14200c86716d14153648ea71f747ace"><code>c2ea08e</code></a> Merge branch 'release-1.40.50'</li> <li><a href="https://github.com/boto/botocore/commit/4fe0c4b511ca2076a59768c864a68964832875cf"><code>4fe0c4b</code></a> Merge branch 'release-1.40.50' into develop</li> <li><a href="https://github.com/boto/botocore/commit/ccf712aeba55bff55fdd1cc335f5c0a71da1ca37"><code>ccf712a</code></a> Bumping version to 1.40.50</li> <li><a href="https://github.com/boto/botocore/commit/9eae5dff043168c807512b9728fc77ca2dec95f5"><code>9eae5df</code></a> Update endpoints model</li> <li>Additional commits viewable in <a href="https://github.com/boto/botocore/compare/1.40.46...1.40.51">compare view</a></li> </ul> </details> <br /> Updates `boto3` from 1.40.46 to 1.40.51 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/boto/boto3/commit/92007179325850ec45c742098b9294cc98df4e03"><code>9200717</code></a> Merge branch 'release-1.40.51'</li> <li><a href="https://github.com/boto/boto3/commit/1a2cda23a5c30704502c19a1f6f09e386325308a"><code>1a2cda2</code></a> Bumping version to 1.40.51</li> <li><a href="https://github.com/boto/boto3/commit/b59d03419e89314689d361a27cc5a23616ba31a3"><code>b59d034</code></a> Add changelog entries from botocore</li> <li><a href="https://github.com/boto/boto3/commit/045a9af984462fcfc501c6bd5491e0bb35c7d958"><code>045a9af</code></a> Bump github/codeql-action from 3.30.0 to 4.30.8 (<a href="https://redirect.github.com/boto/boto3/issues/4638">#4638</a>)</li> <li><a href="https://github.com/boto/boto3/commit/d8b41867dbfac406a2115d87abe1f8caea0365e7"><code>d8b4186</code></a> Merge branch 'release-1.40.50'</li> <li><a href="https://github.com/boto/boto3/commit/f6c0e6606ffb166be3acf79ba7ec143712b26ece"><code>f6c0e66</code></a> Merge branch 'release-1.40.50' into develop</li> <li><a href="https://github.com/boto/boto3/commit/8fc5b245cf38d48dc03a7726be4141911fc09c54"><code>8fc5b24</code></a> Bumping version to 1.40.50</li> <li><a href="https://github.com/boto/boto3/commit/f4d009760a05b09435bd1078c41e7c753246172d"><code>f4d0097</code></a> Add changelog entries from botocore</li> <li><a href="https://github.com/boto/boto3/commit/660a1ec6b8b97d109a8ab37ca5a79925844388f0"><code>660a1ec</code></a> Merge branch 'release-1.40.49'</li> <li><a href="https://github.com/boto/boto3/commit/a5eec708c97fdb2e07179603fc8a42c8c80ad2ca"><code>a5eec70</code></a> Merge branch 'release-1.40.49' into develop</li> <li>Additional commits viewable in <a href="https://github.com/boto/boto3/compare/1.40.46...1.40.51">compare view</a></li> </ul> </details> <br /> Updates `types-python-dateutil` from 2.9.0.20250822 to 2.9.0.20251008 <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/typeshed-internal/stub_uploader/commits">compare view</a></li> </ul> </details> <br /> Updates `pytest-rerunfailures` from 16.0.1 to 16.1 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst">pytest-rerunfailures's changelog</a>.</em></p> <blockquote> <h2>16.1 (2025-10-10)</h2> <ul> <li> <p>Drop support for Python 3.9.</p> </li> <li> <p>Changed "localhost" to "127.0.0.1" to avoid bad hostname resolution.</p> </li> <li> <p>Added <code>--force-reruns</code> to override rerun count globally. Fixes <code>[#306](pytest-dev/pytest-rerunfailures#306) <https://github.com/pytest-dev/pytest-rerunfailures/issues/306></code>_.</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/b01509200f8f782e5666011932886758a50a32c1"><code>b015092</code></a> Preparing release 16.1</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/c1666dd7e53e98228c6fe18f83d23bc3c6b71aa7"><code>c1666dd</code></a> Prepare release.</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/8d04ad96399ccf16575e3395968e957552f98b98"><code>8d04ad9</code></a> Fix <code>NotImplementedError</code> crash when using xdist schedulers without `mark_tes...</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/cb8ede70437ef33a14e4fe2ed612f5f96883d6b2"><code>cb8ede7</code></a> Add a <code>--force-reruns</code> to override rerun count globally (<a href="https://redirect.github.com/pytest-dev/pytest-rerunfailures/issues/307">#307</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/5e011325322460d3340a5b60ddf7bd2f434ff6d0"><code>5e01132</code></a> Bump actions/setup-python from 5 to 6 in the actions group (<a href="https://redirect.github.com/pytest-dev/pytest-rerunfailures/issues/310">#310</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/88e002332ed92dad8d912f31cbd6d82bb8d6c4dd"><code>88e0023</code></a> Drop support for Python 3.9. (<a href="https://redirect.github.com/pytest-dev/pytest-rerunfailures/issues/308">#308</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/df47974727f53b902df4545fc67b0e5862f17c2f"><code>df47974</code></a> Change 'localhost' to '127.0.0.1' (<a href="https://redirect.github.com/pytest-dev/pytest-rerunfailures/issues/305">#305</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-rerunfailures/commit/f149c7dcc7878b2d92b24f860e6e0ff88c7e3f1e"><code>f149c7d</code></a> Back to development: 16.1</li> <li>See full diff in <a href="https://github.com/pytest-dev/pytest-rerunfailures/compare/16.0.1...16.1">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maciej Karaś <maciej.karas@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the diagnostic script to support selecting a tool (oc or kubectl) using the DTOOL environment variable and passing additional flags using DTOOLARGS. The script detects which tools are installed and chooses the preferred tool if specified.
Proof of Work
The script was tested in an environment where both oc and kubectl were installed. It was verified that when no preference was set, the script correctly defaulted to oc. It was also tested with DTOOL set to either oc or kubectl, and in both cases the script correctly used the specified tool.
Checklist
skip-changeloglabel if not needed