-
Notifications
You must be signed in to change notification settings - Fork 24
Fix master builds - it was using BuildScenario.DEVELOPMENT for master merges by mistake #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… merges by mistake
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
… merges by mistake (mongodb#404) # Summary Master merges CI builds are failing. This is because we wrongly interpret them as `BuildScenario.DEVELOPMENT` instead if `BuildScenario.PATCH`. For example [this](https://parsley.mongodb.com/evergreen/mongodb_kubernetes_init_test_run_build_test_image_38b6aa8dae4129bcd35299d679580179481a6980_25_09_04_05_33_35/0/all?bookmarks=0,3863) meko-test build on master pushed image using only latest tag, that is used for `BuildScenario.DEVELOPMENT`. To fix this (before we activate staging builds) we need to return `BuildScenario.PATCH` if `is_patch` is true or `is_evg` true. ## Proof of Work Passing CI for PR is enough. ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
Summary
Master merges CI builds are failing. This is because we wrongly interpret them as
BuildScenario.DEVELOPMENTinstead ifBuildScenario.PATCH.For example this meko-test build on master pushed image using only latest tag, that is used for
BuildScenario.DEVELOPMENT.To fix this (before we activate staging builds) we need to return
BuildScenario.PATCHifis_patchis true oris_evgtrue.Proof of Work
Passing CI for PR is enough.
Checklist
skip-changeloglabel if not needed