-
Notifications
You must be signed in to change notification settings - Fork 24
CLOUDP-342878 - Add --remove-destination to cp #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside
Bug Fixes
Other Changes
|
# Summary Adding the `--remove-destination` flag to `cp` in `setup-agent-files.sh` will prevent the agent container from getting stuck whenever the agent or the utilities container is restarted. If the utilities container is restarted, then the pid of the utilities marker will change. This means that the symlink for the probes are pointing to the filesystem of the old pid, therefore a dangling symlink. When the agent container is restarted, `cp` will not be able to overwrite the symlink without this flag. This change will require re-releasing all agent images. ## Proof of Work Before the change <img width="1488" height="64" alt="image" src="https://github.com/user-attachments/assets/8cc664b9-491a-445b-b71c-2f9b89fa844a" /> After the change. The containers are ready even if they were restarted <img width="1444" height="83" alt="image" src="https://github.com/user-attachments/assets/26f4857a-9f6e-4eca-9e74-82acd5d9f145" /> ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you added changelog file? - use `skip-changelog` label if not needed - refer to [Changelog files and Release Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes) section in CONTRIBUTING.md for more details
Summary
Adding the
--remove-destinationflag tocpinsetup-agent-files.shwill prevent the agent container from getting stuck whenever the agent or the utilities container is restarted.If the utilities container is restarted, then the pid of the utilities marker will change. This means that the symlink for the probes are pointing to the filesystem of the old pid, therefore a dangling symlink. When the agent container is restarted,
cpwill not be able to overwrite the symlink without this flag.This change will require re-releasing all agent images.
Proof of Work
Before the change

After the change. The containers are ready even if they were restarted

Checklist
skip-changeloglabel if not needed