Translations are being stored as a double hash #2483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t just have 'en' set as a hash
|
Thanks for the pull request. However, can you provide a test that shows the expected behaviour please? |
durran
added a commit
that referenced
this pull request
Oct 21, 2012
|
Thanks :) sorry been busy writing this app and needed it to just work, thanks for doing all the tests and stuff On 20 Oct 2012, at 19:40, Durran Jordan notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that translations are being stored wrong because the versioning stuff is simply copying over the key => value and Mongoid::Fields::Localized trying to store that wrongly.
This is just a quick change, it's probably very ugly and needs tests and all sorts but I just kinda thought rather than say there was an issue i'd have a go at trying to fix it