Improve BigDecimal mongoize behavior #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more note here, since |
johnnyshields
changed the title
|
I've raised MONGOID-4165 to track this. |
| @@ -22,18 +70,29 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "when the value is a float" do | |||
| context "when the the value is true" do | |||
There was a problem hiding this comment.
there's an extra 'the' here
|
Hi @johnnyshields |
johnnyshields
force-pushed
the
big-decimal
branch
from
3ecfc00
to
e37535a
Compare
|
@estolfo done. Travis CI running now, looks like it should be good. |
|
thanks! |
| Object.new | ||
| end | ||
|
|
||
| it "returns true" do |
- `demongoize` should always return a BigDecimal or else nil, never an empty string - `mongoize` should always return a String which can be demongoized to a BigDecimal, otherwise or nil - The strings `"Infinity"` and `"-Infinity"` now evaluate as numeric true. - `BigDecimal`s now evaluate as numeric true. - Additional tests for BigDecimal covering all edge cases. - Fix typo "the the" in all specs / comments in repo
johnnyshields
force-pushed
the
big-decimal
branch
from
e37535a
to
d879ee3
Compare
|
@estolfo I fixed all the notes you raised. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I attempted to migrate a number of
Floatfields toBigDecimal, and I found that the behavior is inconsistent between the two. This PR rectifies that situation. Note thatBigDecimalis stored in MongoDB as a string, as there is no native BSON type for it.demongoizeshould always return a BigDecimal or else nil, never an empty string (this mirrors how Floats and Integers behave).mongoizeshould always return a String which can be demongoized to a BigDecimal, otherwise nil"Infinity"and"-Infinity"in the database."Infinity"and"-Infinity"now evaluate as numeric? true.BigDecimals now evaluate as numeric? true.Demongoize
Mongoize