MONGOID-3606 Don't evolve foreign keys of polymorphic relations #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
added a commit
that referenced
this pull request
Jan 26, 2016
MONGOID-3606 Don't evolve foreign keys of polymorphic relations
Contributor
|
The bug report was very old, it was probably already fixed in that version of Mongoid, but it stated:
While this change will ensure that It's desirable for polymorphic foreign keys to be evolved to Object Ids, because it's more consistent with the behaviour for non-polymorphic associations. Could we please revert this? @estolfo |
Contributor
Author
|
In master, it does evolve the foreign key: https://github.com/mongodb/mongoid/blob/master/spec/mongoid/fields/foreign_key_spec.rb#L467 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.