Skip to content

MONGOID-3606 Don't evolve foreign keys of polymorphic relations #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2016
Merged

MONGOID-3606 Don't evolve foreign keys of polymorphic relations #4231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/mongoid/fields/foreign_key.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ def foreign_key?
# @since 3.0.0
def evolve(object)
if object_id_field? || object.is_a?(Document)
object.__evolve_object_id__
if metadata.polymorphic? && constraint
constraint.convert(object)
else
object.__evolve_object_id__
end
else
related_id_field.evolve(object)
end
Expand Down
23 changes: 23 additions & 0 deletions spec/mongoid/fields/foreign_key_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,29 @@
end
end
end

context "when the metadata is polymoprhic" do

let(:metadata) do
Agent.reflect_on_association(:names)
end

let(:field) do
described_class.new(:nameable_id, type: Object, metadata: metadata)
end

let(:value) do
BSON::ObjectId.new().to_s
end

let(:evolved) do
field.evolve(value)
end

it "does not change the foreign key" do
expect(evolved).to be(value)
end
end
end

describe "#lazy?" do
Expand Down