Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-843 Add support for the comment field to all helpers #160

Merged
merged 5 commits into from Apr 22, 2022

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 21, 2022

Some of these were added as part of #158

@juliusgeo
Copy link
Contributor

juliusgeo commented Apr 22, 2022

One thing that could be added is unit tests for the docstrings, similar to my "comment" field PR: https://github.com/juliusgeo/mongo-python-driver/blob/5160ae8da3e802baae44e2a0a5bb84e346cd67be/test/test_comment.py on line 71.

@blink1073
Copy link
Member Author

blink1073 commented Apr 22, 2022

We had to skip that test in #158 because it is checking the signature, and we would have had to update all of the signatures in Motor to be explicit instead of using args and kwargs.

@@ -662,6 +696,9 @@ async def create_x_index():
{'_id_': {'key': [('_id', 1)]},
'x_1': {'unique': True, 'key': [('x', 1)]}}


Copy link
Contributor

@juliusgeo juliusgeo Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this blank line should be placed below.

Copy link
Member Author

@blink1073 blink1073 Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@juliusgeo juliusgeo left a comment

LGTM!

@blink1073 blink1073 merged commit 0b0a360 into mongodb:master Apr 22, 2022
24 checks passed
@blink1073 blink1073 deleted the MOTOR-843 branch Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants