Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-608 Update outdated API docs #165

Merged
merged 2 commits into from Apr 25, 2022
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 25, 2022

No description provided.

Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Nice! A few small suggestions.

this collection is automatically applied to this operation.

:Parameters:
- `keys`: a single key or a list of (key, direction)
Copy link
Member

@ShaneHarvey ShaneHarvey Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing session and comment parameters.

Copy link
Member Author

@blink1073 blink1073 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -1219,3 +1295,285 @@ async def coro():
encrypted = await client_encryption.encrypt(value, ...)
decrypted = await client_encryption.decrypt(encrypted)
"""

gridfs_delete_doc = """Delete a file's metadata and data chunks from a GridFS bucket::
Copy link
Member

@ShaneHarvey ShaneHarvey Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the session parameter to these gridfs docstrings.

Copy link
Member Author

@blink1073 blink1073 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073 blink1073 requested a review from ShaneHarvey Apr 25, 2022
@blink1073 blink1073 merged commit c564a02 into mongodb:master Apr 25, 2022
24 checks passed
@blink1073 blink1073 deleted the MOTOR-608 branch Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants