Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-698 Motor 2 to 3 migration guide #166

Merged
merged 6 commits into from Apr 28, 2022
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 25, 2022

No description provided.

@blink1073 blink1073 marked this pull request as ready for review Apr 27, 2022
doc/migrate-to-motor-3.rst Outdated Show resolved Hide resolved
doc/migrate-to-motor-3.rst Outdated Show resolved Hide resolved
doc/migrate-to-motor-3.rst Show resolved Hide resolved
doc/migrate-to-motor-3.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Show resolved Hide resolved
@blink1073 blink1073 requested a review from ShaneHarvey Apr 27, 2022
choose a `srvMaxHosts` sized subset of hosts.
- Added :attr:`motor.motor_tornado.MotorClient.options` for read-only access
to a client's configuration options.
- Added support for the ``comment`` parameter to all helpers. For example see
Copy link
Member

@ShaneHarvey ShaneHarvey Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment and let support require PyMongo 4.1 so should we bump our min version to 4.1?

Copy link
Member Author

@blink1073 blink1073 Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, as a separate ticket?

Copy link
Member

@ShaneHarvey ShaneHarvey Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah separately makes sense.

- :attr:`~motor.motor_tornado.MotorClient.local_threshold_ms`.
- :attr:`~motor.motor_tornado.MotorClient.server_selection_timeout`.
- :attr:`~motor.motor_tornado.MotorClient.retry_writes`.
- :attr:`~motor.motor_tornado.MotorClient.retry_reads`.
Copy link
Member

@ShaneHarvey ShaneHarvey Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@blink1073 blink1073 Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

doc/changelog.rst Outdated Show resolved Hide resolved
doc/changelog.rst Outdated Show resolved Hide resolved
@blink1073 blink1073 requested a review from ShaneHarvey Apr 27, 2022
Copy link
Contributor

@juliusgeo juliusgeo left a comment

LGTM!

@blink1073 blink1073 merged commit 92b4d51 into mongodb:master Apr 28, 2022
24 checks passed
@blink1073 blink1073 deleted the MOTOR-698 branch Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants