Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-946 Deprecated APIs will not be Removed in Motor 3.0 #168

Merged
merged 2 commits into from Apr 26, 2022

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 25, 2022

No description provided.

@@ -42,6 +42,13 @@ class AgnosticGridOutCursor(AgnosticCursor):

def next_object(self):
"""**DEPRECATED** - Get next GridOut object from cursor."""
warnings.warn(
Copy link
Member

@ShaneHarvey ShaneHarvey Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this raise two duplicate warnings now? I think we omitted this on purpose since the super() call will raise a warning anyway.

Copy link
Member Author

@blink1073 blink1073 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, added a comment instead.

@blink1073 blink1073 requested a review from ShaneHarvey Apr 25, 2022
@blink1073 blink1073 merged commit 2f75a40 into mongodb:master Apr 26, 2022
24 checks passed
@blink1073 blink1073 deleted the MOTOR-946 branch Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants