fix: backport emitWarning helper #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify the way we print out messages relating to upcoming changes or potential misuse of the driver. Using the emitWarning API allows users to configure when and how messages are shown. NODE-2317
nbbeeken
force-pushed
the
chore/port-emitWarningHelper
branch
from
5582cb3
to
989ae6d
Compare
This was referenced Feb 18, 2021
mergeOptionsAndWriteConcern was not updated to use the new format of writeConcern and was causing the the warning about the deprecation to be emitted regardless of user usage. NODE-3114
emadum
approved these changes
Mar 2, 2021
lib/core/connection/msg.js
Outdated
| @@ -196,7 +197,7 @@ class BinMsg { | |||
| while (this.index < this.data.length) { | |||
| const payloadType = this.data.readUInt8(this.index++); | |||
| if (payloadType === 1) { | |||
| console.error('TYPE 1'); | |||
| emitWarning('TYPE 1'); // ??? | |||
There was a problem hiding this comment.
Suggested change
| emitWarning('TYPE 1'); // ??? | |
| // It was decided that no driver makes use of payload type 1 | |
| throw new MongoError('OP_MSG Payload Type 1 detected unsupported protocol'); |
|
#2744 is serious impact to many projects, so when the new 3.6 version will be released to npm registry? Thanks. |
|
We hope to have a release out tomorrow! (March 16) |
|
@nbbeeken appreciate your guys effort! |
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the way we print out messages relating to upcoming changes
or potential misuse of the driver. Using the emitWarning API allows
users to configure when and how messages are shown.
(code from #2740)
NODE-2317, NODE-3114