NODE 1155 - ignoreUndefined is not working in unordered bulkWrite #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
reviewed
Oct 18, 2017
| } | ||
| }); | ||
|
|
||
| it('should ignore undefined values in ordered bulk operation if `ignoreUndefined` specified', { |
There was a problem hiding this comment.
+1 for adding the test for the ordered bulk op too!
mbroadst
reviewed
Oct 18, 2017
| .initializeOrderedBulkOp({ ignoreUndefined: true }) | ||
| .insert({ a: 1, b: undefined }) | ||
| .execute() | ||
| .then(() => col.find({}).toArray()) |
There was a problem hiding this comment.
nitpick: we can use findOne instead of find({}).toArray() to return a single document - I don't think we need to change this, but just consider it in the future
mbroadst
reviewed
Oct 18, 2017
lib/bulk/ordered.js
Outdated
| @@ -502,7 +502,7 @@ var executeCommands = function(self, callback) { | |||
| finalOptions.serializeFunctions = true; | |||
| } | |||
|
|
|||
| // Serialize functions | |||
| // Ingore undefined | |||
There was a problem hiding this comment.
Ignore not Ingore, see: Muphry's law
|
@jlord looks like the tests are failing because those two tests use the same collection name, and never drop the collection between runs resulting in a duplicate key error on the second insert attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the check into unordered bulk operations to see if the
ignoreUndefinedoption has been set totrue.Tests added for both ordered and unordered bulk operations.
Fixes NODE-1155 ✨