Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(merge-params): adds custom merge-params and merge-prop jsdoc #2131

Merged
merged 1 commit into from Sep 17, 2019

Conversation

daprahamian
Copy link
Contributor

Description

Adds custom tags to jsdoc that allow merging parameter and property
definitions:

@merge-params: used in place of a @param whose type is defined
elsewhere. Will expand out all of the properties of the type.

@merge-props: used in a typedef that inherits from another typedef.
Will inherit all properties of that typedef.

Example of ChangeStream now:
change-stream-before

Example of ChangeStream using @merge-params for its options object:
change-stream-after

What changed?

  • adds the plugin to conf.json

Are there any files to ignore?
nope.

Adds custom tags to jsdoc that allow merging parameter and property
definitions:

`@merge-params`: used in place of a @param whose type is defined
elsewhere. Will expand out all of the properties of the type.

`@merge-props`: used in a typedef that inherits from another typedef.
Will inherit all properties of that typedef.
Copy link
Contributor

@kvwalker kvwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Dan, sorry it took so long to get around to reviewing this

@daprahamian daprahamian merged commit f5f9892 into next Sep 17, 2019
@daprahamian daprahamian deleted the add-jsdoc-plugin branch September 17, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants