fix(collection): Add ignoreUndefined option in beginning with findOneAnd* methods. #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Delete, findOneAndReplace methods
changmyeong
changed the title
|
@daprahamian Please feedback here. |
daprahamian
suggested changes
Oct 9, 2019
There was a problem hiding this comment.
Hi @changmyeong,
I prefer the original version. executeOperation is used by a lot more than the crud operations, so adding something in there is not really ideal.
- Dan
…ods" This reverts commit 8d66f2f.
|
@daprahamian Thanks to feedback :) i reverted commit. |
changmyeong
changed the title
changmyeong
changed the title
mbroadst
approved these changes
Oct 9, 2019
|
@daprahamian @mbroadst |
|
@changmyeong sorry about that! It is merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ignoreUndefined option in beginning with findOneAnd* methods.
NODE-2169