Skip to content

Conversation

@tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Oct 13, 2025

Description

Summary of Changes

This PR migrates the integration tests for crud/find_cursor_methods. The changes include:

  • Convert file in typescript
  • Refactor callbacks to async/await
  • Direct import from the src folder
Notes for Reviewers

To simplify the review process there is a separate commit for .js -> .ts conversion.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review October 13, 2025 12:19
@tadjik1 tadjik1 requested a review from a team as a code owner October 13, 2025 12:19
@baileympearson baileympearson self-assigned this Oct 13, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 13, 2025
addaleax
addaleax previously approved these changes Oct 14, 2025
@baileympearson baileympearson merged commit ae08fb5 into main Oct 16, 2025
27 checks passed
@baileympearson baileympearson deleted the NODE-7197 branch October 16, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants