GridStore reference by filename not working #930

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@Reggino

Reggino commented Apr 6, 2013

The feature of the GridStore to lookup a file by it's name just didn't work. This patch should fix that.

As a side note: maybe this feature should be removed AT ALL. Since file names don't have to be unique, the behavior is a bit unpredictable. For a read operation you can't know for sure whether the requested file is correct, for a write operation it's not obvious if you are creating a new file, or appending / overwriting an existing one...

@christkv

This comment has been minimized.

Show comment Hide comment
@christkv

christkv Apr 6, 2013

Member

can you add a failing test ?

you can run the tests by doing

node test/runner.js -t functional

make sure you have mongod in your path so the test runner can find it

Member

christkv commented Apr 6, 2013

can you add a failing test ?

you can run the tests by doing

node test/runner.js -t functional

make sure you have mongod in your path so the test runner can find it

@Reggino

This comment has been minimized.

Show comment Hide comment
@Reggino

Reggino Apr 7, 2013

Continued in pull request #933 (sorry for the fuss)

Reggino commented Apr 7, 2013

Continued in pull request #933 (sorry for the fuss)

@Reggino Reggino closed this Apr 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment