CLOUDP-262013: Upload local Collection to Postman #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
reviewed
Jul 18, 2024
wtrocki
reviewed
Jul 18, 2024
| {"key": "digestAuthPassword", "value": "<string>"}, | ||
| {"key": "realm", "value": "<string>"}]' intermediate1.json > "$COLLECTION_TRANSFORMED_FILE_NAME" | ||
| else | ||
| cp intermediate1.json "$COLLECTION_TRANSFORMED_FILE_NAME" |
Member
There was a problem hiding this comment.
Consider naming that adds collection in the name. I do not mind any format. It can be even
Suggested change
| cp intermediate1.json "$COLLECTION_TRANSFORMED_FILE_NAME" | |
| cp advancedCollection1.json "$COLLECTION_TRANSFORMED_FILE_NAME" |
Contributor
Author
There was a problem hiding this comment.
renamed to intermediateCollection
Collaborator
There was a problem hiding this comment.
bit of a nit; but As a general good practice it might be better to use more meaningful separation of names:
intermediateCollectionUnmodified, intermediateCollectionNoQueryParams, intermediateCollectionNoPostmanId etc
matt-condon
approved these changes
Jul 18, 2024
Collaborator
matt-condon
left a comment
matt-condon
left a comment
There was a problem hiding this comment.
Non-blocking comment - LGTM
wtrocki
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds two scripts to allow the local postman collection to be uploaded to Postman:
Jira ticket: CLOUDP-262013
Checklist
Further comments