Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRIVERS-2411] Add behavior for automatic Azure KMS credentials #1291

Merged
merged 9 commits into from
Sep 26, 2022
Merged

[DRIVERS-2411] Add behavior for automatic Azure KMS credentials #1291

merged 9 commits into from
Sep 26, 2022

Conversation

vector-of-bool
Copy link
Contributor

Refer: DRIVERS-2411

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver. (TODO)
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@vector-of-bool vector-of-bool requested a review from a team as a code owner August 16, 2022 23:26
@vector-of-bool vector-of-bool requested review from kevinAlbs and removed request for a team August 16, 2022 23:26
kevinAlbs
kevinAlbs reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Caching the access token may be a requirement. Consider removing the retry.

source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
kevinAlbs
kevinAlbs reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, changes look good with the removal of one step and additional behavior to cache the token.

To confirm: are test changes going to be included in a later PR?

I will ask if others team members are planning to implement this soon to get more eyes on the review.

source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
source/client-side-encryption/client-side-encryption.rst Outdated Show resolved Hide resolved
@vector-of-bool
Copy link
Contributor Author

I'm just concerned with the base behavior for now, and creating a good testing method is still something I'm thinking over. I'm really averse to requiring a full Azure setup for the simplest tests, and I'm even wary of mocking it, but that might be the only good way to do it.

@vector-of-bool vector-of-bool requested a review from a team as a code owner September 26, 2022 18:07
@vector-of-bool vector-of-bool requested review from jmikola and kevinAlbs and removed request for a team September 26, 2022 18:07
@vector-of-bool
Copy link
Contributor Author

@kevinAlbs Added instructions about token caching.

@vector-of-bool vector-of-bool merged commit d6b8cce into mongodb:master Sep 26, 2022
blink1073
blink1073 reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prestonvasquez prestonvasquez mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 left review comments

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@jmikola jmikola Awaiting requested review from jmikola jmikola is a code owner automatically assigned from mongodb/dbx-spec-owners-unified-test-format

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vector-of-bool @kevinAlbs @blink1073