STITCH-1720 - Implement Server (Node.js) SDK #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
force-pushed
the
STITCH-1720
branch
2 times, most recently
from
f42dd50 to
020480e
Compare
adamchel
approved these changes
Jun 28, 2018
| import StitchUser from "../StitchUser"; | ||
| import StitchUserFactoryImpl from "./StitchUserFactoryImpl"; | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
[nit] Don't think we need any of these Partial things.
| * Partial JSDOM window.location containing only the | ||
| * properties and method we need | ||
| */ | ||
| interface PartialLocaion { |
Contributor
There was a problem hiding this comment.
[nit] assuming this same typo exists in browser, you should probably drive-by fix it there as well as delete here.
| info[DeviceFields.APP_VERSION] = this.appInfo.localAppVersion; | ||
| } | ||
|
|
||
| info[DeviceFields.PLATFORM] = "server"; |
Contributor
There was a problem hiding this comment.
[minor] shouldn't this be node-server or js-server?
packages/server/sdk/README.md
Outdated
| ### Using the SDK | ||
|
|
||
| #### Initialize the SDK | ||
| 1. When your app or webpage is initialized, run the following code to initialize the Stitch SDK, replacing `<your-client-app-id>` with your Stitch application's client app ID: |
Contributor
There was a problem hiding this comment.
[nit] app or webpage -> Node.js service
jsflax
approved these changes
Jun 29, 2018
Contributor
jsflax
left a comment
jsflax
left a comment
There was a problem hiding this comment.
Big PR, but LGTM! Good job on the FileStorage part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.