Skip to content

Conversation

@cbush
Copy link
Contributor

@cbush cbush commented Feb 15, 2019

  • This creates another typedoc plugin because typedoc does
    not generate distinguishable HTML for code blocks vs. inline
    code, so I can't just select on code blocks to add the button.
  • Prefer to do it at build time rather than run time to avoid
    the copy-to-clipboard buttons all popping in.
  • Depends on standalone copy buttons DOCSP-4525 Make standalone copy buttons docs-tools#261

Staged:
https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-4525-examples-copy/sdk/js/index.html

https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-4525-examples-copy/sdk/js-server/index.html

https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-4525-examples-copy/sdk/react-native/index.html

image

@cbush cbush force-pushed the docsp-4525-examples-copy branch 2 times, most recently from a3731f7 to 401367d Compare February 15, 2019 21:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 77.469% when pulling 401367d on cbush:docsp-4525-examples-copy into 54b5c3f on mongodb:master.

@cbush cbush force-pushed the docsp-4525-examples-copy branch 2 times, most recently from a9a5a73 to fc45246 Compare February 19, 2019 15:38
@cbush cbush changed the title [Do not merge] DOCSP-4525 Add 'copy-to-clipboard' for examples DOCSP-4525 Add 'copy-to-clipboard' for examples Feb 19, 2019
Copy link
Contributor

@adamchel adamchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once evergreen passes

- This creates another typedoc plugin because typedoc does
not generate distinguishable HTML for code blocks vs. inline
code, so I can't just select on code blocks to add the button.
- Prefer to do it at build time rather than run time to avoid
the copy-to-clipboard buttons all popping in.
@cbush cbush force-pushed the docsp-4525-examples-copy branch from fc45246 to 6901778 Compare February 20, 2019 16:52
@cbush cbush merged commit 563bc7f into mongodb:master Feb 20, 2019
@cbush cbush deleted the docsp-4525-examples-copy branch February 20, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants