STITCH-2539: Fix the JS-Linter #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaye407
commented
Feb 20, 2019
Contributor
Author
tkaye407
left a comment
tkaye407
left a comment
There was a problem hiding this comment.
To make this PR/CR more manageable I commented in the few spots where you should take a look at what is going on.
packages/browser/core/src/core/internal/net/BrowserFetchStreamTransport.ts
Show resolved
Hide resolved
packages/browser/core/src/core/internal/net/BrowserFetchStreamTransport.ts
Show resolved
Hide resolved
adamchel
suggested changes
Feb 20, 2019
Contributor
adamchel
left a comment
adamchel
left a comment
There was a problem hiding this comment.
This generally LGTM, thanks so much for taking care of this, and thanks a lot for adding the comments, they were super helpful!
I would do the E2E test that I mentioned to make sure redirect state is cleaned, and please answer my other questions but otherwise this will be good to go.
packages/browser/core/src/core/internal/net/BrowserFetchStreamTransport.ts
Show resolved
Hide resolved
packages/server/core/src/core/internal/net/NodeFetchStreamTransport.ts
Outdated
Show resolved
Hide resolved
packages/core/sdk/src/services/internal/CoreStitchServiceClientImpl.ts
Outdated
Show resolved
Hide resolved
| // sourced from https://github.com/coolaj86/TextEncoderLite | ||
| // Sourced from https://github.com/coolaj86/TextEncoderLite | ||
| /** @hidden */ | ||
| /* tslint:disable */ |
Contributor
There was a problem hiding this comment.
sounds good to me, though we should probably include the license of where we sourced this from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.