Method as keyword (not only fields) #47

Merged
merged 5 commits into from Feb 15, 2013

Conversation

Projects
None yet
2 participants
Contributor

tmwh commented Dec 11, 2012

Rewrote Mongoid::Search::Util.keywords, now it can be used with methods as well.
Also, it has to work with more nesting levels than one (not only with parents, but also with grandparents), but it didn't because of mongoid's callback order (durran said he will rewrite it in 4.0.0).
I've added some tests to describe this situation.

Collaborator

mauriciozaffari commented Feb 14, 2013

This pull request cannot be automatically merged anymore. Please take a look and fix the conflicts.

Also, please ensure that no previous functionality is broken. After fixing it I'll merge.

Contributor

tmwh commented Feb 14, 2013

Merged, also all tests are green, so I think previous functionality should not be broken.

mauriciozaffari added a commit that referenced this pull request Feb 15, 2013

Merge pull request #47 from tmwh/master
Method as keyword (not only fields)

@mauriciozaffari mauriciozaffari merged commit 9bcc7cb into mongoid:master Feb 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment