Added a dirty fix for mm-devise/issues/13 issue compatibility with later #487

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

kfam commented Jan 3, 2013

rails3 method assign_attributes and mm-devise

Contributor

jnunemaker commented Jan 3, 2013

Hi,
Thanks for contributing. A few problems. First, you have no tests. In order for me to maintain contributions from others who come and go, I can only pull requests with tests. Second, I don't think update_attributes is what you want to call. Pretty sure you just want to assign the attributes, but update attributes will assign and then also persist the record. I could be wrong, but assign attributes doesn't seem named as if it were to also persist.

kfam commented Jan 4, 2013

Hi,
Sure, I understand your concerns and you are perfectly right. Though, as I a explain to the comment, this is a dirty fix to resolve the issue of raising an exception on use mm-devise with the current release of gem. I'm not sure if is the right way or not. Plus, I'm not sure I'm capable at this time of investigating it further for the tests. I have to look up and understand your gem's code and your tests, also, and on rails how this method is implemented. But, for the time being, i guess, this is a quick fix to the issue raised by this method of not existing, and showing you a path on how to fix it.
Cheers! and Thanks for the response.

jnunemaker closed this Mar 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment