refactor(triggers): share PM status and label decisions#1282
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 9, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - I verified the shared PM status/label helpers preserve the provider-specific parsing and capacity-gate inputs, and the targeted PM trigger tests pass locally.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors PM status-change and ready-to-process label triggers to share decision helpers while keeping provider webhook parsing local.
Card: https://trello.com/c/69fe2a6efef948343f2eb18a
Changes
Testing
npx vitest run --project unit-triggers tests/unit/triggers/shared/pm-status.test.ts tests/unit/triggers/shared/pm-label.test.ts tests/unit/triggers/status-changed.test.ts tests/unit/triggers/backlog-status-changed.test.ts tests/unit/triggers/merged-status-changed.test.ts tests/unit/triggers/jira-status-changed.test.ts tests/unit/triggers/linear-status-changed.test.ts tests/unit/triggers/label-added.test.ts tests/unit/triggers/jira-label-added.test.ts tests/unit/triggers/linear-label-added.test.tsnpm run lint:fixnpm run lintnpm run typechecknpm testNotes
npm run lintexits 0 with two pre-existing complexity warnings insrc/integrations/alerting/_shared/materialize.tsandsrc/triggers/sentry/webhook-handler.ts. No docs updates were needed because this is an internal trigger refactor with no setup or public configuration changes.🕵️ codex · gpt-5.5 · run details