refactor(triggers): thin agent execution facade#1284
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 9, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - The facade remains source-compatible, the extracted runtime/follow-up helpers preserve the previous execution flow, and CI is green.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Card: https://trello.com/c/69fdee572a6522696c72c6f1
This finishes the agent execution facade cleanup by keeping
runAgentExecutionPipeline()as a high-level orchestration path and moving remaining runtime/follow-up details behind helper modules.Changes
agent-execution-runtime.tsfor execution context setup, lifecycle hook loading,runAgent()invocation, post-run PR/work-item linking, PM summaries, and callbacks.agent-execution-followups.tsfor recursive post-completion review dispatch and splitting auto-chain dispatch, while keeping recursion centralized through the facade.biome-ignore lint/complexity/noExcessiveCognitiveComplexitysuppression fromagent-execution.ts.Verification
npx vitest run --project unit-triggers --project unit-core tests/unit/triggers/shared/agent-execution.test.ts tests/unit/triggers/agent-execution.test.ts tests/unit/triggers/shared/webhook-execution.test.ts tests/unit/triggers/sentry-webhook-handler.test.ts tests/unit/pm/webhook-handler.test.tsnpx vitest run --project unit-core tests/unit/architecture-docs.test.tsnpm run lint:fixnpm run lint(passes; reports existing complexity warnings insrc/integrations/alerting/_shared/materialize.tsandsrc/triggers/sentry/webhook-handler.ts)npm run typechecknpm testIntegration tests were not run because this change does not alter handler wiring or credential scope behavior.
🕵️ codex · gpt-5.5 · run details