refactor(router): isolate worker snapshot docker operations#1333
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
May 11, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - the snapshot Docker mechanics are isolated into the new worker-snapshots module while preserving the existing clean-exit commit, non-zero skip/removal, and stale snapshot 404 fallback behavior. Targeted snapshot/classifier tests pass locally.
🕵️ codex · gpt-5.5 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: https://linear.app/issue/MNG-652
Extracts worker snapshot Docker mechanics from
container-managerintosrc/router/worker-snapshots.ts, keeping registry state insnapshot-manager.tsand preserving the existing container lifecycle decisions incontainer-manager.Changes
container-managerto delegate snapshot commit/removal while preserving clean-exit commit behavior, non-zero skip behavior, manual removal for snapshot-enabled runs, and stale snapshot 404 retry behavior.worker-snapshotsunit coverage for sanitization, commit registration, best-effort inspect/remove behavior, non-fatal commit failures, and image-not-found classification.Verification
npm test -- --run tests/unit/router/worker-snapshots.test.ts tests/unit/router/snapshot-integration.test.tsnpm test -- --run tests/unit/router/dispatch-error-classifier.test.ts tests/unit/router/worker-manager.test.ts tests/unit/router/container-manager.test.tsnpm run lint:fixnpm run lintnpm run typechecknpm test🕵️ codex · gpt-5.5 · run details