Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add artisan command to create new account #4745

Merged
merged 13 commits into from Jan 31, 2021

Conversation

codemonkeysoftware
Copy link

This adds an Account:Create command to artisan so that accounts can be created on an instance without opening public registration.

Resolves #4744

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2020

CLA assistant check
All committers have signed the CLA.

fix style errors
fix error call
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thank you.
See my review

app/Console/Commands/CreateAccount.php Outdated Show resolved Hide resolved
app/Console/Commands/CreateAccount.php Show resolved Hide resolved
Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

app/Console/Commands/CreateAccount.php Outdated Show resolved Hide resolved
@asbiin asbiin enabled auto-merge (squash) January 1, 2021 11:21
@djaiss
Copy link
Member

djaiss commented Jan 1, 2021

Good, thank you!

@codemonkeysoftware
Copy link
Author

I'm fairly certain the suddenly failing tests are coincidental to my adding a new test, but maybe I'm wrong?

@asbiin
Copy link
Member

asbiin commented Jan 3, 2021

@lpdyck no it's not. I'm trying to resolve it in #4763

@asbiin asbiin disabled auto-merge January 3, 2021 15:06
@asbiin asbiin merged commit b9ee793 into monicahq:master Jan 31, 2021
@asbiin
Copy link
Member

asbiin commented Jan 31, 2021

Thank you @lpdyck !

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create User command for artisan
4 participants