Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export data as json format #4779

Merged
merged 79 commits into from Jan 11, 2022
Merged

feat: export data as json format #4779

merged 79 commits into from Jan 11, 2022

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Jan 9, 2021

This resolves #32
It's also related to #3104
It will also close #355

The idea is to export datas with json format, with a flat, simple structure
There are 1 root data "account" that contains "users", "contacts", and other datas for config: activityTypes, activityTypesCategories, etc.
All datas related to contact are detailed in the contact itself.

Photos and documents are serialized directly in the json file (which is not the case with the sql export)

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing job. Now that the code review is done, I'll test it.

Also: very good idea to create ExportResources objects.

app/Http/Controllers/SettingsController.php Outdated Show resolved Hide resolved
app/Http/Controllers/SettingsController.php Outdated Show resolved Hide resolved
config/monica.php Outdated Show resolved Hide resolved
@asbiin asbiin requested a review from djaiss January 7, 2022 22:46
@djaiss
Copy link
Member

djaiss commented Jan 8, 2022

@asbiin In an empty account, I added one contact, then exported my data in Json. It failed, and I have no idea why.

@asbiin
Copy link
Member Author

asbiin commented Jan 9, 2022

@asbiin In an empty account, I added one contact, then exported my data in Json. It failed, and I have no idea why.

I cannot reproduce it, it works fine with me. Don't you have any exception in your log file?

@asbiin asbiin temporarily deployed to monica-team-2020-12-18--747s3g January 9, 2022 18:39 Inactive
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--747s3g January 9, 2022 19:28 Inactive
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--2wpocv January 9, 2022 19:37 Inactive
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--15yscg January 9, 2022 21:17 Inactive
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--15yscg January 11, 2022 20:27 Inactive
public/changelog.json Outdated Show resolved Hide resolved
Co-authored-by: Regis Freyd <djaiss@users.noreply.github.com>
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--15yscg January 11, 2022 20:29 Inactive
@asbiin asbiin temporarily deployed to monica-team-2020-12-18--15yscg January 11, 2022 20:30 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

68.1% 68.1% Coverage
0.0% 0.0% Duplication

@asbiin asbiin changed the title feat: export datas as json format feat: export data as json format Jan 11, 2022
@asbiin asbiin merged commit 8c627a2 into master Jan 11, 2022
@asbiin asbiin deleted the 2020-12-18-json-export branch January 11, 2022 20:41
@github-actions
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create UUIDs for data types to be shared via API / Webhooks Add export function in JSON
4 participants