Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow delete any reminder + fix reminder edit data #5582

Merged
merged 2 commits into from Oct 9, 2021

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Oct 9, 2021

This allows to

  • delete any reminder
  • edit any reminder which is not a birthday reminder

It also fix data displayed on edit a reminder: current values were not used.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 981a639 into master Oct 9, 2021
@asbiin asbiin deleted the 20211009-reminder-edit branch October 9, 2021 11:01
@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant