Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API contact properties update + documents + photos + avatar #3302

Merged
merged 24 commits into from
Dec 18, 2019

Conversation

asbiin
Copy link
Member

@asbiin asbiin commented Dec 14, 2019

Close #2716
Close #2905

Adds some api routes:

  • PUT /contacts/{contact}/work to update work informations
  • PUT /contacts/{contact}/food to update food preferences
  • PUT /contacts/{contact}/introduction to update the firstMet information
  • PUT /contacts/{contact}/avatar to update the avatar of a contact
  • POST /documents to store a new document
  • DELETE /documents/{document} to destroy a document
  • GET /photos to get every photos
  • GET /photos/{photo} to get one photo
  • POST /photos to upload a photo (contact_id required to link it to the photo)
  • DELETE /photos/{photo} to destroy a photo

@asbiin asbiin requested a review from djaiss December 14, 2019 11:23
@asbiin asbiin changed the title feat: add API contact properties update feat: add API contact properties update + documents + photos + avatar Dec 15, 2019
@asbiin
Copy link
Member Author

asbiin commented Dec 15, 2019

@djaiss I've updated the content of this PR recently, would you like to review it please?

Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @asbiin 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
app/Services/Contact/Avatar/UpdateAvatar.php Outdated Show resolved Hide resolved
asbiin and others added 6 commits December 17, 2019 20:12
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Copy link
Member Author

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @asbiin +1

Thanks!

@asbiin asbiin merged commit 99f84c2 into master Dec 18, 2019
@asbiin asbiin deleted the feat/api-contact-properties-2019-12-14 branch December 18, 2019 21:55
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API for avatars Fix missing API contact fields store/update
2 participants