Skip to content

feat: add API contact properties update + documents + photos + avatar#3302

Merged
asbiin merged 24 commits into
masterfrom
feat/api-contact-properties-2019-12-14
Dec 18, 2019
Merged

feat: add API contact properties update + documents + photos + avatar#3302
asbiin merged 24 commits into
masterfrom
feat/api-contact-properties-2019-12-14

Conversation

@asbiin

@asbiin asbiin commented Dec 14, 2019

Copy link
Copy Markdown
Member

Close #2716
Close #2905

Adds some api routes:

  • PUT /contacts/{contact}/work to update work informations
  • PUT /contacts/{contact}/food to update food preferences
  • PUT /contacts/{contact}/introduction to update the firstMet information
  • PUT /contacts/{contact}/avatar to update the avatar of a contact
  • POST /documents to store a new document
  • DELETE /documents/{document} to destroy a document
  • GET /photos to get every photos
  • GET /photos/{photo} to get one photo
  • POST /photos to upload a photo (contact_id required to link it to the photo)
  • DELETE /photos/{photo} to destroy a photo

@asbiin asbiin requested a review from djaiss December 14, 2019 11:23
@asbiin asbiin changed the title feat: add API contact properties update feat: add API contact properties update + documents + photos + avatar Dec 15, 2019
@asbiin

asbiin commented Dec 15, 2019

Copy link
Copy Markdown
Member Author

@djaiss I've updated the content of this PR recently, would you like to review it please?

Comment thread app/Helpers/DBHelper.php
Comment thread app/Http/Controllers/Contacts/PhotosController.php

@djaiss djaiss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @asbiin 👍

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread app/Services/Contact/Contact/UpdateContactWork.php
Comment thread app/Services/Contact/Contact/UpdateContactFoodPreferences.php Outdated
Comment thread app/Services/Contact/Contact/UpdateContactFoodPreferences.php Outdated
Comment thread app/Services/Contact/Contact/UpdateContactIntroductions.php Outdated
Comment thread tests/Api/Contact/ApiContactControllerTest.php
Comment thread app/Services/Contact/Avatar/UpdateAvatar.php Outdated
asbiin and others added 6 commits December 17, 2019 20:12
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>
Co-Authored-By: Regis Freyd <djaiss@users.noreply.github.com>

@asbiin asbiin left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @asbiin +1

Thanks!

@asbiin asbiin merged commit 99f84c2 into master Dec 18, 2019
@asbiin asbiin deleted the feat/api-contact-properties-2019-12-14 branch December 18, 2019 21:55
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API for avatars Fix missing API contact fields store/update

2 participants