New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Dist-Zilla. #7

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@shlomif

shlomif commented Feb 3, 2016

This is done as part of the pull-request challenge. Module-Install is undermaintained and unloved.

@shlomif

This comment has been minimized.

Show comment
Hide comment
@shlomif

shlomif Nov 29, 2016

Hi all! Why wasn't this pull-request merged (or at least dismissed with a useful comment yet)? Ping!

shlomif commented Nov 29, 2016

Hi all! Why wasn't this pull-request merged (or at least dismissed with a useful comment yet)? Ping!

@sni

This comment has been minimized.

Show comment
Hide comment
@sni

sni Nov 30, 2016

Contributor

I don't see the advantage to add Dist-Zilla as new (build) dependency. Module-Install just works and does everything we need.

Contributor

sni commented Nov 30, 2016

I don't see the advantage to add Dist-Zilla as new (build) dependency. Module-Install just works and does everything we need.

@shlomif

This comment has been minimized.

Show comment
Hide comment
@shlomif

shlomif Dec 1, 2016

@sni: hi! Sorry for the late reply. Some of the advantages of Dist-Zilla over Module-Install:

  1. Ability to generate a META.json file.

  2. Module-Install has become abandoned and unmaintained.

  3. Module-Install will break with upcoming perl 5's that will remove . from the installation path by default.

  4. Module-Install plugins are hard to figure out and install.

  5. Dist-Zilla is not required to install the distribution from CPAN, just to build from the VM.

shlomif commented Dec 1, 2016

@sni: hi! Sorry for the late reply. Some of the advantages of Dist-Zilla over Module-Install:

  1. Ability to generate a META.json file.

  2. Module-Install has become abandoned and unmaintained.

  3. Module-Install will break with upcoming perl 5's that will remove . from the installation path by default.

  4. Module-Install plugins are hard to figure out and install.

  5. Dist-Zilla is not required to install the distribution from CPAN, just to build from the VM.

@sni

This comment has been minimized.

Show comment
Hide comment
@sni

sni Dec 27, 2016

Contributor

I just tried to this PR.

  1. It fails to build the module:
[DZ] beginning to build Monitoring-Plugin
[DZ] guessing dist's main_module is lib/Monitoring/Plugin.pm
[@Filter/ExtraTests] rewriting author test xt/author/pod-syntax.t
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Config.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/ExitResult.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Getopt.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Performance.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Range.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Threshold.pm"
[DZ] attempt to add META.yml multiple times; added by: filename set by GatherDir (Dist::Zilla::Plugin::GatherDir line 225); encoded_content added by @Filter/GatherDir (Dist::Zilla::Plugin::GatherDir line 226); text from coderef added by @Filter/MetaYAML (Dist::Zilla::Plugin::MetaYAML line 70)
aborting; duplicate files would be produced at /home/sven/perl5/lib/perl5/Dist/Zilla/App/Command/build.pm line 75.
  1. The tests also fail.

  2. I am a bit worried about pulling in a new dependency which itself has so many depencencies. It even requires Moose just to build a module.

But so far i don't see any advantage besides being more modern.

Contributor

sni commented Dec 27, 2016

I just tried to this PR.

  1. It fails to build the module:
[DZ] beginning to build Monitoring-Plugin
[DZ] guessing dist's main_module is lib/Monitoring/Plugin.pm
[@Filter/ExtraTests] rewriting author test xt/author/pod-syntax.t
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Config.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/ExitResult.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Getopt.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Performance.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Range.pm"
[RewriteVersion] Skipping: no "our $VERSION = '...'" found in "lib/Monitoring/Plugin/Threshold.pm"
[DZ] attempt to add META.yml multiple times; added by: filename set by GatherDir (Dist::Zilla::Plugin::GatherDir line 225); encoded_content added by @Filter/GatherDir (Dist::Zilla::Plugin::GatherDir line 226); text from coderef added by @Filter/MetaYAML (Dist::Zilla::Plugin::MetaYAML line 70)
aborting; duplicate files would be produced at /home/sven/perl5/lib/perl5/Dist/Zilla/App/Command/build.pm line 75.
  1. The tests also fail.

  2. I am a bit worried about pulling in a new dependency which itself has so many depencencies. It even requires Moose just to build a module.

But so far i don't see any advantage besides being more modern.

@sni sni closed this Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment