Permalink
Browse files

fix smart attribute comparison

Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN
that threshold an error is reported.  This patch fixes the problem, that
attribute values EQUAL to the threshold are reported as error, which is wrong.
Only LESSTHAN the threshold is an error.

For more information see: http://www.hdsentinel.com/smart/index.php

My SSD has some attributes which value and threshold are "0". Without the patch
this is reported as errornous.

ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE
...
172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0
174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13
177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0
...

See also:

* http://sourceforge.net/p/nagiosplug/patches/365/
* https://bugzilla.redhat.com/913085
  • Loading branch information...
1 parent 49ae05f commit c4a99b023d03326ad49e03c8731eec19d19a75bf Tilmann Bubeck committed with dermoth Oct 25, 2011
Showing with 3 additions and 3 deletions.
  1. +3 −3 plugins/check_ide_smart.c
@@ -349,7 +349,7 @@ values_not_passed (values_t * p, thresholds_t * t)
int i;
for (i = 0; i < NR_ATTRIBUTES; i++) {
if (value->id && threshold->id && value->id == threshold->id) {
- if (value->value <= threshold->threshold) {
+ if (value->value < threshold->threshold) {
++failed;
}
else {
@@ -378,7 +378,7 @@ nagios (values_t * p, thresholds_t * t)
int i;
for (i = 0; i < NR_ATTRIBUTES; i++) {
if (value->id && threshold->id && value->id == threshold->id) {
- if (value->value <= threshold->threshold) {
+ if (value->value < threshold->threshold) {
++failed;
if (value->status & 1) {
status = PREFAILURE;
@@ -435,7 +435,7 @@ print_value (value_t * p, threshold_t * t)
printf ("Id=%3d, Status=%2d {%s , %s}, Value=%3d, Threshold=%3d, %s\n",
p->id, p->status, p->status & 1 ? "PreFailure" : "Advisory ",
p->status & 2 ? "OnLine " : "OffLine", p->value, t->threshold,
- p->value > t->threshold ? "Passed" : "Failed");
+ p->value >= t->threshold ? "Passed" : "Failed");
}

0 comments on commit c4a99b0

Please sign in to comment.