Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint .py and .pl scripts #1365

Closed
glensc opened this issue Oct 5, 2015 · 6 comments
Closed

lint .py and .pl scripts #1365

glensc opened this issue Oct 5, 2015 · 6 comments

Comments

@glensc
Copy link
Contributor

glensc commented Oct 5, 2015

to avoid such mistakes like distributing scripts with syntax error, imho would be good if travis syntax lints the scripts. perl -c script.pl, python -m py_compile script.py

@sni
Copy link
Contributor

sni commented Oct 5, 2015

We do this since yesterday already :-)
c0b4f41
At least for perl scripts. I am not aware of any python scripts.

@sni sni closed this as completed Oct 5, 2015
@glensc
Copy link
Contributor Author

glensc commented Oct 5, 2015

yeah, it was discussed in IRC on Friday, but didn't think somebody actually will implement it that soon, and i myself did not have time :)

but anyway, it can be done for python as well.

@glensc
Copy link
Contributor Author

glensc commented Oct 5, 2015

oh. no .py indeed. where did i see .py then? :)

@waja
Copy link
Member

waja commented Oct 5, 2015

The idea behind of implementing it soon was, if we delay it, it will never happen. :-)

@glensc
Copy link
Contributor Author

glensc commented Oct 5, 2015

otoh, if all plugins are tested for functionality, the syntax check is not needed ;)

@waja
Copy link
Member

waja commented Oct 5, 2015

this syntax check is good for having an indicator for people creating RPs, for exampel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants