Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge button is not automatically enabled when approve criteria are met #21

Closed
j-vizcaino opened this issue Sep 30, 2015 · 1 comment
Closed

Merge button is not automatically enabled when approve criteria are met #21

j-vizcaino opened this issue Sep 30, 2015 · 1 comment
Labels
enhancement

Comments

@j-vizcaino
Copy link

How to reproduce:

  • configure PR-Harmony to allow PR to be merge when at least 1 dev has approved
  • go to PR, merge button is disabled (because it needs approval from 1 person in the list)
  • click approve (you are one of the mandatory reviewers)
  • merge button is still disabled.
  • refresh the page, the merge button is now enabled
@monitorjbl
Copy link
Owner

@j-vizcaino yeah, this is definitely a known issue with Stash. Basically, clicking Approve doesn't force the UI to recheck if the PR is mergable. PR Harmony could have a Javascript hook to force a page reload on approval events though.

monitorjbl added a commit that referenced this issue Feb 28, 2016
@monitorjbl
adding javascript hook to make merge check on approval (#21)
3c73253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monitorjbl @j-vizcaino