Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelable.cancel() should return Unit and not Boolean #115

Closed
alexandru opened this Issue Jan 28, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

alexandru commented Jan 28, 2016

We've used Cancelable.cancel() for synchronization.

It's useful, but it imposes a synchronization burden on cancel (beyond the idempotency guarantee) and it's not compatible with other similar interfaces.

@alexandru

This comment has been minimized.

Copy link
Member Author

alexandru commented Mar 2, 2016

Done.

@alexandru alexandru closed this Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.