Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify contract of AsyncScheduler, add a new ExecutorScheduler #125

Closed
alexandru opened this Issue Mar 10, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@alexandru
Copy link
Member

alexandru commented Mar 10, 2016

Two related issues in one:

  • the AsyncScheduler should always execute tasks on the given ExecutionContext, even delayed ones. The given ScheduledExecutorService should only be used for the delayed scheduling of tasks, but not for their execution.
  • introduce an ExecutorScheduler that wraps a ScheduledExecutorService, along with a Scheduler.fixedPool builder that uses it to build a fixed pool Scheduler

@alexandru alexandru added this to the 1.1 milestone Mar 10, 2016

@alexandru alexandru self-assigned this Mar 10, 2016

alexandru added a commit that referenced this issue Mar 10, 2016

alexandru added a commit that referenced this issue Mar 10, 2016

@mkej

This comment has been minimized.

Copy link

mkej commented Mar 10, 2016

Looks good! Can't wait to ditch my workaround in favor of above changes.

alexandru added a commit that referenced this issue Mar 11, 2016

@alexandru alexandru closed this Mar 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.