Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ack.Cancel to Ack.Stop #131

Closed
alexandru opened this Issue Mar 21, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

commented Mar 21, 2016

Related to issue #123, because we now treat Cancelable.cancel() separately and not simulated with an Ack.Cancel as in version 1.0, we have to differentiate between the two operations.

Ack's Cancel is renamed to Stop. Stop is a synchronous command with a guaranteed immediate effect: the producer must cease to produce onNext events immediately.

Cancelable.cancel on the other hand is an operation that is concurrent with the Observer's onNext, onError and onComplete notifications and isn't guaranteed to stop the stream immediately or at all.
The English language defines "cancel" as a verb meaning "to decide or announce that (a planned event) will not take place". That seems to be a match for the wanted semantic.

A type alias type Cancel = Stop will be provided in order to lessen the migration curve.

@alexandru

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2016

Done.

@alexandru alexandru closed this Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.