Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.onCancelTriggerError #132

Closed
alexandru opened this Issue Mar 21, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

alexandru commented Mar 21, 2016

Now that we have the protocol changes (from #123) and the rename of Cancel to Stop (in #131), we should provide an onCancelTriggerError operator that, when the subscription gets canceled, the observer should be terminated with a CancellationException.

Because calling cancel() is concurrent with the observer events, this operator will need heavy synchronization. However it goes against the intended usage for cancel() anyway, being meant for exceptions, so that's OK.

alexandru added a commit that referenced this issue Mar 22, 2016

@alexandru

This comment has been minimized.

Copy link
Member Author

alexandru commented Apr 8, 2016

Done.

@alexandru alexandru closed this Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.