Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the buffer operators #160

Closed
alexandru opened this Issue Jun 14, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

alexandru commented Jun 14, 2016

Identified problems that need to be solved:

  • The bufferTimed operator currently does not have the same behavior as its ReactiveX equivalent and that's unfortunate because it's less useful and not intuitive
  • We also need a bufferWithSelector that emits bundles whenever a selector observable emits items
  • The bufferWithSelector also needs a variant with a maxSize that back-pressures the source when the buffer is full
  • The plain buffer(count, skip) operation in normal Scala parlance is called sliding and we should indicate that in the name, such that people can find it by using auto-complete or when searching in the API documentation

Breaking Changes:

  • buffer(count) gets renamed to bufferTumbling (similar with RxScala)
  • buffer(count,skip) gets renamed to bufferSliding (similar with Scala and RxScala)
  • bufferTimed(timespan) gets refactored to have similar to ReactiveX
  • bufferTimed(timespan, maxSize) gets renamed to bufferTimedAndCounted(timespan, maxCount)
  • new bufferTimedWithPressure(timespan, maxSize) operator, that is like bufferTimed but applies back-pressure on the source when the buffer is full
  • new bufferWithSelector(selector) operator that emits bundles whenever the selector observable emits events
  • new bufferWithSelector(selector, maxSize) operator that emits bundles whenever the selector observable emits events and that back-pressures the source when the buffer size reaches maxSize

@alexandru alexandru added this to the 2.0 milestone Jun 14, 2016

@alexandru alexandru self-assigned this Jun 14, 2016

alexandru added a commit that referenced this issue Jun 14, 2016

@alexandru

This comment has been minimized.

Copy link
Member Author

alexandru commented Jun 15, 2016

Released in 2.0-RC6

@alexandru alexandru closed this Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.