Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the ConcurrentSubject and Pipe constructors #161

Closed
alexandru opened this Issue Jun 14, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

commented Jun 14, 2016

Shamefully, given that 2.0 final is close, there are some constructors from ConcurrentSubject and Pipe that are changing, so here are some breaking changes that hopefully are not hard to address:

  • Get rid of MulticastStrategy.ReplayPopulated as it's not that useful (versus just the Replay strategy)
  • The Multicast.ReplayLimited should take an initial Seq argument
  • Pipe.publish, Pipe.publishToOne, Pipe.async, Pipe.replay no longer need the empty parens (), given that the instance returned is not mutable, Pipe being a factory
  • Pipe.behavior should no longer take a lazy initial value, as that was a mistake
  • Pipe.replayPopulated to be renamed to an overload of Pipe.replay
  • Pipe.replayLimited should take an overload accepting an initial Seq of prepopulated elements
  • Pipe.concurrent should take an overload that does not take an OverflowStrategy, defaulting to Unbounded
  • All ConcurrentSubject builders should have overloads that do not take an OverflowStrategy, thus defaulting to Unbounded
  • ConcurrentSubject.async should have its own implementation, since buffering doesn't make sense for AsyncSubject
  • Concurrent.replayPopulated should be renamed to replay, to be consistent with Pipe
  • ReplaySubject.createWithSize should be renamed to createLimited to be consistent with Pipe.replayLimited

@alexandru alexandru added this to the 2.0 milestone Jun 14, 2016

@alexandru alexandru self-assigned this Jun 14, 2016

alexandru added a commit that referenced this issue Jun 14, 2016

@alexandru

This comment has been minimized.

Copy link
Member Author

commented Jun 15, 2016

Released in 2.0-RC6

@alexandru alexandru closed this Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.