Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task.mapBoth is not stack safe #194

Closed
alexandru opened this Issue Jul 22, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

commented Jul 22, 2016

Reported by @guersam in PR #188, if you gather 10000 tasks, it will fail with a StackOverflowException. The Task.gather operation is based on mapBoth, as do other operations.

The reason for why it isn't stack safe is because in mapBoth we need to execute a mapping function over the result of two tasks and running this over a big list, like in gather, ends up chaining onSuccess calls that get executed synchronously and that will trigger stack overflows for lists that are big enough.

@alexandru alexandru added the bug label Jul 22, 2016

@alexandru alexandru added this to the 2.0 milestone Jul 22, 2016

@alexandru alexandru self-assigned this Jul 22, 2016

alexandru added a commit that referenced this issue Jul 22, 2016

@alexandru alexandru closed this in cc409d7 Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.