Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeCancelable.remove doesn't work #211

Closed
alexandru opened this Issue Aug 22, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@alexandru
Copy link
Member

commented Aug 22, 2016

Bug was introduced in 2.0-RC10. It has already been fixed in 2.0-RC11. Adding this ticket in order to document it.

Critical bug

It's actually a big problem that CompositeCancelable.remove does not actually remove references, because this capability is used in Observable.merge and in Observable.concat. So basically this translates into a memory leak.

The cause for why this bug escaped into a release was that CompositeCancelable.remove was not unit tested. So taking this opportunity to review the code coverage of all cancelables and add tests where needed.

@alexandru alexandru added the bug label Aug 22, 2016

@alexandru alexandru added this to the 2.0 milestone Aug 22, 2016

@alexandru alexandru self-assigned this Aug 22, 2016

alexandru added a commit that referenced this issue Aug 22, 2016

@alexandru

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

Was already fixed, tests were added.

@alexandru alexandru closed this Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.